-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add various options #433
base: master
Are you sure you want to change the base?
Add various options #433
Conversation
I tried this change but the top bar is still visible for me. I tested with the simplest form using this command: The below command didn't work either: |
@mr2rm Which window manager are you using? It might not support removing the title bar of an existing window. Could you test using these commands?
After executing click on a Kitty window. |
@lennartack I tried that in Ubuntu and I use the default window manager of Ubuntu, the Gnome Shell. Also, I tested the two commands you sent but didn't get any output. |
@mr2rm These |
@mr2rm I see others are using a hexadecimal notation for the values with
|
@lennartack Any of the commands you mentioned don't work. Apparently, Gnome Shell doesn't support that. I had to use the below extension to get the job done. I couldn't find any other solution. |
This should all be possible without new flags (or if a new hook is necessary, I'd accept a PR for that). I'd accept a PR to add an example to the FAQ in the readme about sticky, but I'd rather not directly add this to tdrop. Better to just use whatever will work work for one's specific WM in a hook I think (wmctrl is also not currently a dependency of tdrop). Let me know if there's anything that would need to be changed directly in tdrop to support this. |
@noctuid The title bar removal would require a new hook. It needs to execute before the window dimensions and location are changed by tdrop but after the window id is known. |
That said, having these flags would make it much less painful to switch to tdrop on floating window managers. Guake and Yakuake work out of the box on many WMs, so it might be worth checking out how they do it and if there is a Bash equivalent. Even if you need different code for different WMs I think it's still worth it. |
I did some more research about the title bar removal. Guake also seems to use I guess adding C code is outside the scope of this project, so we can't have this option on many WMs. I think we need a |
These options make tdrop behave more like other drop-down terminals. Fixes #432.